Fix various problems for building and running tests in GitHub CI #90
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jatkinson1000
force-pushed
the
jwa-ci-dependencies-patch
branch
from
d5feafc to
dc4e19f
Compare
It is a binary, but unlikely to change and cannot be generated in the CI due to issues with netcdf save in python requiring os.getlogin which doesn't work on CI runners for some reason (similar issues can be found elsewhere).
…aded as NetCDF file.
jatkinson1000
force-pushed
the
jwa-ci-dependencies-patch
branch
5 times, most recently
from
a6e6a7a to
d6ed18b
Compare
jatkinson1000
force-pushed
the
jwa-ci-dependencies-patch
branch
from
d6ed18b to
ca2326a
Compare
|
Note I had issues getting the exported |
…version updates in future.
|
This should allow you to check off
from #89 and move to generating exit codes for when tests fail. |
jatkinson1000
changed the title
AdelekeBankole
approved these changes
Jan 15, 2025
omarjamil
approved these changes
Jan 15, 2025
Co-authored-by: Marion <56403724+MarionBWeinzierl@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Patch to #89
Initially removed dependency pinning from sounding generation file, but there were still issues (documented various places online) with running netcdf.save on GitHub CI so I have uploaded the NetCDF file as an artifact to fix this.
I also added netCDF-Fortran that was missing from the dependencies.
Also fixes the ruff errors and pins version to avoid this in future.
Both CI checks now run, and pass.
Next stage will be for @AdelekeBankole to focus on adding exit codes to failing Fortran tests so that they appear in the CI output.